lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0976/1095] posix-cpu-timers: Cleanup CPU timers before freeing them during exec
    Date
    From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

    commit e362359ace6f87c201531872486ff295df306d13 upstream.

    Commit 55e8c8eb2c7b ("posix-cpu-timers: Store a reference to a pid not a
    task") started looking up tasks by PID when deleting a CPU timer.

    When a non-leader thread calls execve, it will switch PIDs with the leader
    process. Then, as it calls exit_itimers, posix_cpu_timer_del cannot find
    the task because the timer still points out to the old PID.

    That means that armed timers won't be disarmed, that is, they won't be
    removed from the timerqueue_list. exit_itimers will still release their
    memory, and when that list is later processed, it leads to a
    use-after-free.

    Clean up the timers from the de-threaded task before freeing them. This
    prevents a reported use-after-free.

    Fixes: 55e8c8eb2c7b ("posix-cpu-timers: Store a reference to a pid not a task")
    Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20220809170751.164716-1-cascardo@canonical.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/exec.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/fs/exec.c
    +++ b/fs/exec.c
    @@ -1297,6 +1297,9 @@ int begin_new_exec(struct linux_binprm *
    bprm->mm = NULL;

    #ifdef CONFIG_POSIX_TIMERS
    + spin_lock_irq(&me->sighand->siglock);
    + posix_cpu_timers_exit(me);
    + spin_unlock_irq(&me->sighand->siglock);
    exit_itimers(me);
    flush_itimer_signals();
    #endif

    \
     
     \ /
      Last update: 2022-08-16 01:14    [W:2.180 / U:1.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site