lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 0285/1157] ARM: dts: qcom: msm8974: Disable remoteprocs by default
    Date
    From: Stephan Gerhold <stephan.gerhold@kernkonzept.com>

    [ Upstream commit 8d8be8dd7c1f5d50f84ecc7a6a41962da48c6164 ]

    The remoteproc configuration in qcom-msm8974.dtsi is incomplete because
    it lacks the regulator supplies that should be added in the board DT
    files. Some of the msm8974 boards are currently missing the regulator
    supplies and should have the remoteprocs disabled to avoid making use
    of the incomplete configuration.

    This also fixes dtbs_check warnings after moving "qcom,msm8974-mss-pil"
    to DT schema, which rightfully complains that the -supply properties
    are missing for some boards:

    qcom-apq8074-dragonboard.dtb:
    remoteproc@fc880000: 'pll-supply' is a required property
    From schema: remoteproc/qcom,msm8916-mss-pil.yaml
    remoteproc@fc880000: 'mss-supply' is a required property
    From schema: remoteproc/qcom,msm8916-mss-pil.yaml
    remoteproc@fc880000: 'oneOf' conditional failed, one must be fixed:
    'power-domains' is a required property
    'power-domain-names' is a required property, or
    'cx-supply' is a required property
    'mx-supply' is a required property

    Cc: Luca Weiss <luca@z3ntu.xyz>
    Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
    Fixes: f300826d27be ("ARM: dts: qcom-msm8974: Sort and clean up nodes")
    Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220712124421.3129206-4-stephan.gerhold@kernkonzept.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++++
    arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts | 2 ++
    arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 2 ++
    3 files changed, 8 insertions(+)

    diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
    index 3c31c95aa6b9..2d9416d1a6c8 100644
    --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
    +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
    @@ -1182,6 +1182,8 @@ remoteproc_mss: remoteproc@fc880000 {
    qcom,smem-states = <&modem_smp2p_out 0>;
    qcom,smem-state-names = "stop";

    + status = "disabled";
    +
    mba {
    memory-region = <&mba_region>;
    };
    @@ -1662,6 +1664,8 @@ remoteproc_adsp: remoteproc@fe200000 {
    qcom,smem-states = <&adsp_smp2p_out 0>;
    qcom,smem-state-names = "stop";

    + status = "disabled";
    +
    smd-edge {
    interrupts = <GIC_SPI 156 IRQ_TYPE_EDGE_RISING>;

    diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
    index 58cb2ce1e4df..8a6b8e4de887 100644
    --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
    +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
    @@ -147,10 +147,12 @@ wcnss {
    };

    &remoteproc_adsp {
    + status = "okay";
    cx-supply = <&pm8841_s2>;
    };

    &remoteproc_mss {
    + status = "okay";
    cx-supply = <&pm8841_s2>;
    mss-supply = <&pm8841_s3>;
    mx-supply = <&pm8841_s1>;
    diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
    index d6b2300a8223..577cbffad010 100644
    --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
    +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
    @@ -457,10 +457,12 @@ fuelgauge_pin: fuelgauge-int-pin {
    };

    &remoteproc_adsp {
    + status = "okay";
    cx-supply = <&pma8084_s2>;
    };

    &remoteproc_mss {
    + status = "okay";
    cx-supply = <&pma8084_s2>;
    mss-supply = <&pma8084_s6>;
    mx-supply = <&pma8084_s1>;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 01:11    [W:3.271 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site