lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0831/1095] ASoC: mt6797-mt6351: Fix refcount leak in mt6797_mt6351_dev_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: f0ab0bf250da ("ASoC: add mt6797-mt6351 driver and config option")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220603083417.9011-1-linmq006@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/mediatek/mt6797/mt6797-mt6351.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
    index 496f32bcfb5e..d2f6213a6bfc 100644
    --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c
    +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
    @@ -217,7 +217,8 @@ static int mt6797_mt6351_dev_probe(struct platform_device *pdev)
    if (!codec_node) {
    dev_err(&pdev->dev,
    "Property 'audio-codec' missing or invalid\n");
    - return -EINVAL;
    + ret = -EINVAL;
    + goto put_platform_node;
    }
    for_each_card_prelinks(card, i, dai_link) {
    if (dai_link->codecs->name)
    @@ -230,6 +231,9 @@ static int mt6797_mt6351_dev_probe(struct platform_device *pdev)
    dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",
    __func__, ret);

    + of_node_put(codec_node);
    +put_platform_node:
    + of_node_put(platform_node);
    return ret;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 00:33    [W:4.089 / U:0.888 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site