lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0764/1095] RDMA/irdma: Fix a window for use-after-free
    Date
    From: Mustafa Ismail <mustafa.ismail@intel.com>

    [ Upstream commit 8ecef7890b3aea78c8bbb501a4b5b8134367b821 ]

    During a destroy CQ an interrupt may cause processing of a CQE after CQ
    resources are freed by irdma_cq_free_rsrc(). Fix this by moving the call
    to irdma_cq_free_rsrc() after the irdma_sc_cleanup_ceqes(), which is
    called under the cq_lock.

    Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
    Link: https://lore.kernel.org/r/20220705230815.265-6-shiraz.saleem@intel.com
    Signed-off-by: Bartosz Sobczak <bartosz.sobczak@intel.com>
    Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
    Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/irdma/verbs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
    index 6daa149dcbda..b29631f6659a 100644
    --- a/drivers/infiniband/hw/irdma/verbs.c
    +++ b/drivers/infiniband/hw/irdma/verbs.c
    @@ -1760,11 +1760,11 @@ static int irdma_destroy_cq(struct ib_cq *ib_cq, struct ib_udata *udata)
    spin_unlock_irqrestore(&iwcq->lock, flags);

    irdma_cq_wq_destroy(iwdev->rf, cq);
    - irdma_cq_free_rsrc(iwdev->rf, iwcq);

    spin_lock_irqsave(&iwceq->ce_lock, flags);
    irdma_sc_cleanup_ceqes(cq, ceq);
    spin_unlock_irqrestore(&iwceq->ce_lock, flags);
    + irdma_cq_free_rsrc(iwdev->rf, iwcq);

    return 0;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-16 00:24    [W:3.137 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site