lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0720/1095] phy: ti: tusb1210: Dont check for write errors when powering on
    Date
    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    [ Upstream commit d4a0a189b72a7c98e4256292b18b67c69fbc9343 ]

    On some platforms, like Intel Merrifield, the writing values during power on
    may timeout:

    tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80
    phy phy-dwc3.0.auto.ulpi.0: phy poweron failed --> -110
    dwc3 dwc3.0.auto: error -ETIMEDOUT: failed to initialize core
    dwc3: probe of dwc3.0.auto failed with error -110

    which effectively fails the probe of the USB controller.
    Drop the check as it was before the culprit commit (see Fixes tag).

    Fixes: 09a3512681b3 ("phy: ti: tusb1210: Improve ulpi_read()/_write() error checking")
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Acked-by: Hans de Goede <hdegoede@redhat.com>
    Tested-by: Ferry Toth <fntoth@gmail.com>
    Link: https://lore.kernel.org/r/20220613160848.82746-1-andriy.shevchenko@linux.intel.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/ti/phy-tusb1210.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c
    index c3ab4b69ea68..669c13d6e402 100644
    --- a/drivers/phy/ti/phy-tusb1210.c
    +++ b/drivers/phy/ti/phy-tusb1210.c
    @@ -105,8 +105,9 @@ static int tusb1210_power_on(struct phy *phy)
    msleep(TUSB1210_RESET_TIME_MS);

    /* Restore the optional eye diagram optimization value */
    - return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2,
    - tusb->vendor_specific2);
    + tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, tusb->vendor_specific2);
    +
    + return 0;
    }

    static int tusb1210_power_off(struct phy *phy)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 23:58    [W:2.974 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site