lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0492/1095] can: usb_8dev: do not report txerr and rxerr during bus-off
    Date
    From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

    [ Upstream commit aebe8a2433cd090ccdc222861f44bddb75eb01de ]

    During bus off, the error count is greater than 255 and can not fit in
    a u8.

    Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices")
    Link: https://lore.kernel.org/all/20220719143550.3681-10-mailhol.vincent@wanadoo.fr
    Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/can/usb/usb_8dev.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c
    index b638604bf1ee..ea63dc687fdb 100644
    --- a/drivers/net/can/usb/usb_8dev.c
    +++ b/drivers/net/can/usb/usb_8dev.c
    @@ -439,9 +439,10 @@ static void usb_8dev_rx_err_msg(struct usb_8dev_priv *priv,

    if (rx_errors)
    stats->rx_errors++;
    -
    - cf->data[6] = txerr;
    - cf->data[7] = rxerr;
    + if (priv->can.state != CAN_STATE_BUS_OFF) {
    + cf->data[6] = txerr;
    + cf->data[7] = rxerr;
    + }

    priv->bec.txerr = txerr;
    priv->bec.rxerr = rxerr;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 23:24    [W:4.079 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site