lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0450/1095] mediatek: mt76: eeprom: fix missing of_node_put() in mt76_find_power_limits_node()
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 3bd53ea02d77917c2314ec7be9e2d05be22f87d3 ]

    We should use of_node_put() for the reference 'np' returned by
    of_get_child_by_name() which will increase the refcount.

    Fixes: 22b980badc0f ("mt76: add functions for parsing rate power limits from DT")
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/eeprom.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
    index a499861918fa..9bc8758573fc 100644
    --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
    +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
    @@ -162,10 +162,13 @@ mt76_find_power_limits_node(struct mt76_dev *dev)
    }

    if (mt76_string_prop_find(country, dev->alpha2) ||
    - mt76_string_prop_find(regd, region_name))
    + mt76_string_prop_find(regd, region_name)) {
    + of_node_put(np);
    return cur;
    + }
    }

    + of_node_put(np);
    return fallback;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 23:15    [W:4.021 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site