lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0394/1095] drm/vc4: hdmi: Avoid full hdmi audio fifo writes
    Date
    From: Dom Cobley <popcornmix@gmail.com>

    [ Upstream commit 1c594eeccf92368177c2e22f1d3ee4933dfb8567 ]

    We are getting occasional VC4_HD_MAI_CTL_ERRORF in
    HDMI_MAI_CTL which seem to correspond with audio dropouts.

    Reduce the threshold where we deassert DREQ to avoid the fifo
    overfilling

    Fixes: bb7d78568814 ("drm/vc4: Add HDMI audio support")
    Signed-off-by: Dom Cobley <popcornmix@gmail.com>
    Link: https://lore.kernel.org/r/20220613144800.326124-21-maxime@cerno.tech
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vc4/vc4_hdmi.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
    index 0fe04b1f9782..114b007a1e6e 100644
    --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
    +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
    @@ -1626,10 +1626,10 @@ static int vc4_hdmi_audio_prepare(struct device *dev, void *data,

    /* Set the MAI threshold */
    HDMI_WRITE(HDMI_MAI_THR,
    - VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_PANICHIGH) |
    - VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_PANICLOW) |
    - VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_DREQHIGH) |
    - VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_DREQLOW));
    + VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_PANICHIGH) |
    + VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_PANICLOW) |
    + VC4_SET_FIELD(0x06, VC4_HD_MAI_THR_DREQHIGH) |
    + VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_DREQLOW));

    HDMI_WRITE(HDMI_MAI_CONFIG,
    VC4_HDMI_MAI_CONFIG_BIT_REVERSE |
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 23:09    [W:2.306 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site