lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0377/1095] media: sta2x11: remove VIRT_TO_BUS dependency
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit a157802359f7451ed8046b2b6dbaca187797e062 ]

    This driver does not use the virt_to_bus() function, though it
    depends on x86 specific fixups in the swiotlb code, which was
    last rewritten in commit e380a0394c36 ("x86/PCI: sta2x11: use
    default DMA address translation").

    It is possible that the driver still fails to build on some
    architectures that are missing CONFIG_VIRT_TO_BUS, but it is
    always set on x86 machines with the STA2X11 platform enabled.

    More likely though is that it was never meant to depend on
    CONFIG_VIRT_TO_BUS, and the Kconfig dependency was kept from
    an out-of-tree version when the driver was originally merged.

    Fixes: efeb98b4e2b2 ("[media] STA2X11 VIP: new V4L2 driver")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/sta2x11/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/pci/sta2x11/Kconfig b/drivers/media/pci/sta2x11/Kconfig
    index a96e170ab04e..118b922c08c3 100644
    --- a/drivers/media/pci/sta2x11/Kconfig
    +++ b/drivers/media/pci/sta2x11/Kconfig
    @@ -1,7 +1,7 @@
    # SPDX-License-Identifier: GPL-2.0-only
    config STA2X11_VIP
    tristate "STA2X11 VIP Video For Linux"
    - depends on PCI && VIDEO_DEV && VIRT_TO_BUS && I2C
    + depends on PCI && VIDEO_DEV && I2C
    depends on STA2X11 || COMPILE_TEST
    select GPIOLIB if MEDIA_SUBDRV_AUTOSELECT
    select VIDEO_ADV7180 if MEDIA_SUBDRV_AUTOSELECT
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 23:06    [W:4.129 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site