lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0381/1095] media: tw686x: Fix memory leak in tw686x_video_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit e0b212ec9d8177d6f7c404315293f6a085d6ee42 ]

    video_device_alloc() allocates memory for vdev,
    when video_register_device() fails, it doesn't release the memory and
    leads to memory leak, call video_device_release() to fix this.

    Fixes: 704a84ccdbf1 ("[media] media: Support Intersil/Techwell TW686x-based video capture cards")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/tw686x/tw686x-video.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
    index b227e9e78ebd..37a20fe24241 100644
    --- a/drivers/media/pci/tw686x/tw686x-video.c
    +++ b/drivers/media/pci/tw686x/tw686x-video.c
    @@ -1282,8 +1282,10 @@ int tw686x_video_init(struct tw686x_dev *dev)
    video_set_drvdata(vdev, vc);

    err = video_register_device(vdev, VFL_TYPE_VIDEO, -1);
    - if (err < 0)
    + if (err < 0) {
    + video_device_release(vdev);
    goto error;
    + }
    vc->num = vdev->num;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 23:06    [W:3.553 / U:1.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site