lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0343/1095] net: ag71xx: fix discards const qualifier warning
    Date
    From: Oleksij Rempel <o.rempel@pengutronix.de>

    [ Upstream commit 225b0ed27e6ac523e5e98e7395392446859c7f20 ]

    Current kernel will compile this driver with warnings. This patch will
    fix it.

    drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_fast_reset':
    drivers/net/ethernet/atheros/ag71xx.c:996:31: warning: passing argument 2 of 'ag71xx_hw_set
    _macaddr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    996 | ag71xx_hw_set_macaddr(ag, dev->dev_addr);
    | ~~~^~~~~~~~~~
    drivers/net/ethernet/atheros/ag71xx.c:951:69: note: expected 'unsigned char *' but argument
    is of type 'const unsigned char *'
    951 | static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
    | ~~~~~~~~~~~~~~~^~~
    drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_open':
    drivers/net/ethernet/atheros/ag71xx.c:1441:32: warning: passing argument 2 of 'ag71xx_hw_se
    t_macaddr' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1441 | ag71xx_hw_set_macaddr(ag, ndev->dev_addr);
    | ~~~~^~~~~~~~~~
    drivers/net/ethernet/atheros/ag71xx.c:951:69: note: expected 'unsigned char *' but argument
    is of type 'const unsigned char *'
    951 | static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
    | ~~~~~~~~~~~~~~~^~~

    Fixes: adeef3e32146 ("net: constify netdev->dev_addr")
    Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/atheros/ag71xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
    index ec167af0e3b2..5041265f4226 100644
    --- a/drivers/net/ethernet/atheros/ag71xx.c
    +++ b/drivers/net/ethernet/atheros/ag71xx.c
    @@ -946,7 +946,7 @@ static unsigned int ag71xx_max_frame_len(unsigned int mtu)
    return ETH_HLEN + VLAN_HLEN + mtu + ETH_FCS_LEN;
    }

    -static void ag71xx_hw_set_macaddr(struct ag71xx *ag, unsigned char *mac)
    +static void ag71xx_hw_set_macaddr(struct ag71xx *ag, const unsigned char *mac)
    {
    u32 t;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 22:58    [W:2.322 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site