lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0324/1095] drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 7d255ddbbf679aa47e041cbf68520fd985ed2279 ]

    of_graph_get_remote_node() returns remote device nodepointer with
    refcount incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220601033927.47814-2-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/meson/meson_encoder_cvbs.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
    index fd8db97ba8ba..8110a6e39320 100644
    --- a/drivers/gpu/drm/meson/meson_encoder_cvbs.c
    +++ b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
    @@ -238,6 +238,7 @@ int meson_encoder_cvbs_init(struct meson_drm *priv)
    }

    meson_encoder_cvbs->next_bridge = of_drm_find_bridge(remote);
    + of_node_put(remote);
    if (!meson_encoder_cvbs->next_bridge) {
    dev_err(priv->dev, "Failed to find CVBS Connector bridge\n");
    return -EPROBE_DEFER;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 22:55    [W:2.738 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site