lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0308/1095] drm/st7735r: Fix module autoloading for Okaya RH128128T
    Date
    From: Javier Martinez Canillas <javierm@redhat.com>

    [ Upstream commit 9ad6f181ad9a19a26bda73a7b199df44ccfcdaba ]

    The SPI core always reports a "MODALIAS=spi:<foo>", even if the device was
    registered via OF. This means that the st7735r.ko module won't autoload if
    a DT has a node with a compatible "okaya,rh128128t" string.

    In that case, kmod expects a "MODALIAS=of:N*T*Cokaya,rh128128t" uevent but
    instead will get a "MODALIAS=spi:rh128128t", which is not present in the
    list of aliases:

    $ modinfo drivers/gpu/drm/tiny/st7735r.ko | grep alias
    alias: of:N*T*Cokaya,rh128128tC*
    alias: of:N*T*Cokaya,rh128128t
    alias: of:N*T*Cjianda,jd-t18003-t01C*
    alias: of:N*T*Cjianda,jd-t18003-t01
    alias: spi:jd-t18003-t01

    To workaround this issue, add in the SPI table an entry for that device.

    Fixes: d1d511d516f7 ("drm: tiny: st7735r: Add support for Okaya RH128128T")
    Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Acked-by: David Lechner <david@lechnology.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220520091602.179078-1-javierm@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/tiny/st7735r.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c
    index 29d618093e94..e0f02d367d88 100644
    --- a/drivers/gpu/drm/tiny/st7735r.c
    +++ b/drivers/gpu/drm/tiny/st7735r.c
    @@ -174,6 +174,7 @@ MODULE_DEVICE_TABLE(of, st7735r_of_match);

    static const struct spi_device_id st7735r_id[] = {
    { "jd-t18003-t01", (uintptr_t)&jd_t18003_t01_cfg },
    + { "rh128128t", (uintptr_t)&rh128128t_cfg },
    { },
    };
    MODULE_DEVICE_TABLE(spi, st7735r_id);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 22:54    [W:4.122 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site