lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0245/1095] soc: qcom: aoss: Fix refcount leak in qmp_cooling_devices_register
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit e6e0951414a314e7db3e9e24fd924b3e15515288 ]

    Every iteration of for_each_available_child_of_node() decrements
    the reference count of the previous node.
    When breaking early from a for_each_available_child_of_node() loop,
    we need to explicitly call of_node_put() on the child node.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 05589b30b21a ("soc: qcom: Extend AOSS QMP driver to support resources that are used to wake up the SoC.")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220606064252.42595-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/qcom/qcom_aoss.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
    index a59bb34e5eba..18c856056475 100644
    --- a/drivers/soc/qcom/qcom_aoss.c
    +++ b/drivers/soc/qcom/qcom_aoss.c
    @@ -399,8 +399,10 @@ static int qmp_cooling_devices_register(struct qmp *qmp)
    continue;
    ret = qmp_cooling_device_add(qmp, &qmp->cooling_devs[count++],
    child);
    - if (ret)
    + if (ret) {
    + of_node_put(child);
    goto unroll;
    + }
    }

    if (!count)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 22:44    [W:4.060 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site