lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0181/1095] pinctrl: Dont allow PINCTRL_AMD to be a module
    Date
    From: Mario Limonciello <mario.limonciello@amd.com>

    [ Upstream commit 41ef3c1a6bb0fd4a3f81170dd17de3adbff80783 ]

    It was observed that by allowing pinctrl_amd to be loaded
    later in the boot process that interrupts sent to the GPIO
    controller early in the boot are not serviced. The kernel treats
    these as a spurious IRQ and disables the IRQ.

    This problem was exacerbated because it happened on a system with
    an encrypted partition so the kernel object was not accesssible for
    an extended period of time while waiting for a passphrase.

    To avoid this situation from occurring, stop allowing pinctrl-amd
    from being built as a module and instead require it to be built-in
    or disabled.

    Reported-by: madcatx@atlas.cz
    Suggested-by: jwrdegoede@fedoraproject.org
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=216230
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    Acked-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20220713175950.964-1-mario.limonciello@amd.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
    index f52960d2dfbe..bff144c97e66 100644
    --- a/drivers/pinctrl/Kconfig
    +++ b/drivers/pinctrl/Kconfig
    @@ -32,7 +32,7 @@ config DEBUG_PINCTRL
    Say Y here to add some extra checks and diagnostics to PINCTRL calls.

    config PINCTRL_AMD
    - tristate "AMD GPIO pin control"
    + bool "AMD GPIO pin control"
    depends on HAS_IOMEM
    depends on ACPI || COMPILE_TEST
    select GPIOLIB
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 22:33    [W:4.017 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site