lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0094/1095] scsi: lpfc: Remove extra atomic_inc on cmd_pending in queuecommand after VMID
    Date
    From: James Smart <jsmart2021@gmail.com>

    commit 0948a9c5386095baae4012190a6b65aba684a907 upstream.

    VMID introduced an extra increment of cmd_pending, causing double-counting
    of the I/O. The normal increment ios performed in lpfc_get_scsi_buf.

    Link: https://lore.kernel.org/r/20220701211425.2708-5-jsmart2021@gmail.com
    Fixes: 33c79741deaf ("scsi: lpfc: vmid: Introduce VMID in I/O path")
    Cc: <stable@vger.kernel.org> # v5.14+
    Co-developed-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: Justin Tee <justin.tee@broadcom.com>
    Signed-off-by: James Smart <jsmart2021@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/lpfc/lpfc_scsi.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/scsi/lpfc/lpfc_scsi.c
    +++ b/drivers/scsi/lpfc/lpfc_scsi.c
    @@ -5710,7 +5710,6 @@ lpfc_queuecommand(struct Scsi_Host *shos
    cur_iocbq->cmd_flag |= LPFC_IO_VMID;
    }
    }
    - atomic_inc(&ndlp->cmd_pending);

    #ifdef CONFIG_SCSI_LPFC_DEBUG_FS
    if (unlikely(phba->hdwqstat_on & LPFC_CHECK_SCSI_IO))

    \
     
     \ /
      Last update: 2022-08-15 22:28    [W:4.146 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site