lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0122/1095] usb: typec: ucsi: Acknowledge the GET_ERROR_STATUS command completion
    Date
    From: Linyu Yuan <quic_linyyuan@quicinc.com>

    commit a7dc438b5e446afcd1b3b6651da28271400722f2 upstream.

    We found PPM will not send any notification after it report error status
    and OPM issue GET_ERROR_STATUS command to read the details about error.

    According UCSI spec, PPM may clear the Error Status Data after the OPM
    has acknowledged the command completion.

    This change add operation to acknowledge the command completion from PPM.

    Fixes: bdc62f2bae8f (usb: typec: ucsi: Simplified registration and I/O API)
    Cc: <stable@vger.kernel.org> # 5.10
    Signed-off-by: Jack Pham <quic_jackp@quicinc.com>
    Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
    Link: https://lore.kernel.org/r/1658817949-4632-1-git-send-email-quic_linyyuan@quicinc.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/typec/ucsi/ucsi.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/usb/typec/ucsi/ucsi.c
    +++ b/drivers/usb/typec/ucsi/ucsi.c
    @@ -76,6 +76,10 @@ static int ucsi_read_error(struct ucsi *
    if (ret)
    return ret;

    + ret = ucsi_acknowledge_command(ucsi);
    + if (ret)
    + return ret;
    +
    switch (error) {
    case UCSI_ERROR_INCOMPATIBLE_PARTNER:
    return -EOPNOTSUPP;

    \
     
     \ /
      Last update: 2022-08-15 22:26    [W:2.216 / U:3.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site