lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0092/1095] iio: fix iio_format_avail_range() printing for none IIO_VAL_INT
    Date
    From: Fawzi Khaber <fawzi.khaber@tdk.com>

    commit 5e1f91850365de55ca74945866c002fda8f00331 upstream.

    iio_format_avail_range() should print range as follow [min, step, max], so
    the function was previously calling iio_format_list() with length = 3,
    length variable refers to the array size of values not the number of
    elements. In case of non IIO_VAL_INT values each element has integer part
    and decimal part. With length = 3 this would cause premature end of loop
    and result in printing only one element.

    Signed-off-by: Fawzi Khaber <fawzi.khaber@tdk.com>
    Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
    Fixes: eda20ba1e25e ("iio: core: Consolidate iio_format_avail_{list,range}()")
    Link: https://lore.kernel.org/r/20220718130706.32571-1-jmaneyrol@invensense.com
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/industrialio-core.c | 18 +++++++++++++++++-
    1 file changed, 17 insertions(+), 1 deletion(-)

    --- a/drivers/iio/industrialio-core.c
    +++ b/drivers/iio/industrialio-core.c
    @@ -821,7 +821,23 @@ static ssize_t iio_format_avail_list(cha

    static ssize_t iio_format_avail_range(char *buf, const int *vals, int type)
    {
    - return iio_format_list(buf, vals, type, 3, "[", "]");
    + int length;
    +
    + /*
    + * length refers to the array size , not the number of elements.
    + * The purpose is to print the range [min , step ,max] so length should
    + * be 3 in case of int, and 6 for other types.
    + */
    + switch (type) {
    + case IIO_VAL_INT:
    + length = 3;
    + break;
    + default:
    + length = 6;
    + break;
    + }
    +
    + return iio_format_list(buf, vals, type, length, "[", "]");
    }

    static ssize_t iio_read_channel_info_avail(struct device *dev,

    \
     
     \ /
      Last update: 2022-08-15 22:23    [W:2.275 / U:1.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site