lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0081/1095] drm/nouveau: Dont pm_runtime_put_sync(), only pm_runtime_put_autosuspend()
    Date
    From: Lyude Paul <lyude@redhat.com>

    commit c96cfaf8fc02d4bb70727dfa7ce7841a3cff9be2 upstream.

    While trying to fix another issue, it occurred to me that I don't actually
    think there is any situation where we want pm_runtime_put() in nouveau to
    be synchronous. In fact, this kind of just seems like it would cause
    issues where we may unexpectedly block a thread we don't expect to be
    blocked.

    So, let's only use pm_runtime_put_autosuspend().

    Changes since v1:
    * Use pm_runtime_put_autosuspend(), not pm_runtime_put()

    Signed-off-by: Lyude Paul <lyude@redhat.com>
    Reviewed-by: David Airlie <airlied@linux.ie>
    Fixes: 3a6536c51d5d ("drm/nouveau: Intercept ACPI_VIDEO_NOTIFY_PROBE")
    Cc: Hans de Goede <hdegoede@redhat.com>
    Cc: <stable@vger.kernel.org> # v4.10+
    Link: https://patchwork.freedesktop.org/patch/msgid/20220714174234.949259-3-lyude@redhat.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
    drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpu/drm/nouveau/nouveau_display.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
    @@ -515,7 +515,7 @@ nouveau_display_hpd_work(struct work_str

    pm_runtime_mark_last_busy(drm->dev->dev);
    noop:
    - pm_runtime_put_sync(drm->dev->dev);
    + pm_runtime_put_autosuspend(dev->dev);
    }

    #ifdef CONFIG_ACPI
    --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
    @@ -466,7 +466,7 @@ nouveau_fbcon_set_suspend_work(struct wo
    if (state == FBINFO_STATE_RUNNING) {
    nouveau_fbcon_hotplug_resume(drm->fbcon);
    pm_runtime_mark_last_busy(drm->dev->dev);
    - pm_runtime_put_sync(drm->dev->dev);
    + pm_runtime_put_autosuspend(drm->dev->dev);
    }
    }


    \
     
     \ /
      Last update: 2022-08-15 22:18    [W:2.706 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site