lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 0020/1095] HID: nintendo: Add missing array termination
    Date
    From: Guenter Roeck <linux@roeck-us.net>

    commit ab5f3404b7762b88403fbddbdda6b1b464bd6cbc upstream.

    joycon_dpad_inputs_jc[] is unterminated. This may result in odd warnings
    such as

    input: input_set_capability: invalid code 3077588140 for type 1

    or in kernel crashes in nintendo_hid_probe(). Terminate the array to fix
    the problem.

    Fixes: 2af16c1f846bd ("HID: nintendo: add nintendo switch controller driver")
    Cc: Daniel J. Ogorchock <djogorchock@gmail.com>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/hid/hid-nintendo.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/hid/hid-nintendo.c
    +++ b/drivers/hid/hid-nintendo.c
    @@ -1586,6 +1586,7 @@ static const unsigned int joycon_button_
    /* We report joy-con d-pad inputs as buttons and pro controller as a hat. */
    static const unsigned int joycon_dpad_inputs_jc[] = {
    BTN_DPAD_UP, BTN_DPAD_DOWN, BTN_DPAD_LEFT, BTN_DPAD_RIGHT,
    + 0 /* 0 signals end of array */
    };

    static int joycon_input_create(struct joycon_ctlr *ctlr)

    \
     
     \ /
      Last update: 2022-08-15 22:08    [W:2.542 / U:1.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site