lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 388/779] HID: amd_sfh: Dont show client init failed as error when discovery fails
    Date
    From: Mario Limonciello <mario.limonciello@amd.com>

    [ Upstream commit e51d8d3ea3d773334d2c047c8d1623dba66f592a ]

    When sensor discovery fails, this means that the system doesn't have
    any sensors connected and a user should only be notified at most one time.
    A message is already displayed at WARN level of "failed to discover,
    sensors not enabled". It's pointless to show that the client init failed
    at ERR level for the same condition.

    Check the return code and don't display this message in those conditions.

    Fixes: b5d7f43e97da ("HID: amd_sfh: Add support for sensor discovery")
    Reported-by: David Chang <David.Chang@amd.com>
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
    index ae8f1f2536e9..13a4db42cd7a 100644
    --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
    +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
    @@ -323,7 +323,8 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
    rc = amd_sfh_hid_client_init(privdata);
    if (rc) {
    amd_sfh_clear_intr(privdata);
    - dev_err(&pdev->dev, "amd_sfh_hid_client_init failed\n");
    + if (rc != -EOPNOTSUPP)
    + dev_err(&pdev->dev, "amd_sfh_hid_client_init failed\n");
    return rc;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:06    [W:2.280 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site