lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 378/779] wifi: rtw88: check the return value of alloc_workqueue()
    Date
    From: William Dean <williamsukatube@gmail.com>

    [ Upstream commit 42bbf810e155efc6129a3a648ae5300f00b79d7b ]

    The function alloc_workqueue() in rtw_core_init() can fail, but
    there is no check of its return value. To fix this bug, its return value
    should be checked with new error handling code.

    Fixes: fe101716c7c9d ("rtw88: replace tx tasklet with work queue")
    Reported-by: Hacash Robot <hacashRobot@santino.com>
    Signed-off-by: William Dean <williamsukatube@gmail.com>
    Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
    Signed-off-by: Kalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/20220723063756.2956189-1-williamsukatube@163.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/realtek/rtw88/main.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
    index 69512856bb46..5786995d90d4 100644
    --- a/drivers/net/wireless/realtek/rtw88/main.c
    +++ b/drivers/net/wireless/realtek/rtw88/main.c
    @@ -1819,6 +1819,10 @@ int rtw_core_init(struct rtw_dev *rtwdev)
    timer_setup(&rtwdev->tx_report.purge_timer,
    rtw_tx_report_purge_timer, 0);
    rtwdev->tx_wq = alloc_workqueue("rtw_tx_wq", WQ_UNBOUND | WQ_HIGHPRI, 0);
    + if (!rtwdev->tx_wq) {
    + rtw_warn(rtwdev, "alloc_workqueue rtw_tx_wq failed\n");
    + return -ENOMEM;
    + }

    INIT_DELAYED_WORK(&rtwdev->watch_dog_work, rtw_watch_dog_work);
    INIT_DELAYED_WORK(&coex->bt_relink_work, rtw_coex_bt_relink_work);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:05    [W:3.865 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site