lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 212/779] blktrace: Trace remapped requests correctly
    Date
    From: Bart Van Assche <bvanassche@acm.org>

    [ Upstream commit 22c80aac882f712897b88b7ea8f5a74ea19019df ]

    Trace the remapped operation and its flags instead of only the data
    direction of remapped operations. This issue was detected by analyzing
    the warnings reported by sparse related to the new blk_opf_t type.

    Reviewed-by: Jun'ichi Nomura <junichi.nomura@nec.com>
    Cc: Mike Snitzer <snitzer@kernel.org>
    Cc: Mike Christie <michael.christie@oracle.com>
    Cc: Li Zefan <lizf@cn.fujitsu.com>
    Cc: Chaitanya Kulkarni <kch@nvidia.com>
    Fixes: 1b9a9ab78b0a ("blktrace: use op accessors")
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Link: https://lore.kernel.org/r/20220714180729.1065367-11-bvanassche@acm.org
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/trace/blktrace.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
    index c42ff77eb6cc..eaa98e2b468f 100644
    --- a/kernel/trace/blktrace.c
    +++ b/kernel/trace/blktrace.c
    @@ -1058,7 +1058,7 @@ static void blk_add_trace_rq_remap(void *ignore, struct request *rq, dev_t dev,
    r.sector_from = cpu_to_be64(from);

    __blk_add_trace(bt, blk_rq_pos(rq), blk_rq_bytes(rq),
    - rq_data_dir(rq), 0, BLK_TA_REMAP, 0,
    + req_op(rq), rq->cmd_flags, BLK_TA_REMAP, 0,
    sizeof(r), &r, blk_trace_request_get_cgid(rq));
    rcu_read_unlock();
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 20:43    [W:2.332 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site