lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 159/779] ARM: bcm: Fix refcount leak in bcm_kona_smc_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit cb23389a2458c2e4bfd6c86a513cbbe1c4d35e76 ]

    of_find_matching_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: b8eb35fd594a ("ARM: bcm281xx: Add L2 cache enable code")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/mach-bcm/bcm_kona_smc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
    index 43829e49ad93..347bfb7f03e2 100644
    --- a/arch/arm/mach-bcm/bcm_kona_smc.c
    +++ b/arch/arm/mach-bcm/bcm_kona_smc.c
    @@ -52,6 +52,7 @@ int __init bcm_kona_smc_init(void)
    return -ENODEV;

    prop_val = of_get_address(node, 0, &prop_size, NULL);
    + of_node_put(node);
    if (!prop_val)
    return -EINVAL;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 20:38    [W:2.464 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site