Messages in this thread | | | Date | Sat, 13 Aug 2022 18:18:50 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v1 07/10] net: dsa: microchip: warn about not supported synclko properties on KSZ9893 chips |
| |
On Sat, Aug 13, 2022 at 05:11:45PM +0200, Andrew Lunn wrote: > On Sat, Aug 13, 2022 at 04:32:15PM +0200, Oleksij Rempel wrote: > > On Fri, Aug 05, 2022 at 04:42:34PM +0300, Vladimir Oltean wrote: > > > On Fri, Aug 05, 2022 at 01:56:01PM +0200, Oleksij Rempel wrote: > > > > Hm, if we will have any random not support OF property in the switch > > > > node. We won't be able to warn about it anyway. So, if it is present > > > > but not supported, we will just ignore it. > > > > > > > > I'll drop this patch. > > > > > > To continue, I think the right way to go about this is to edit the > > > dt-schema to say that these properties are only applicable to certain > > > compatible strings, rather than for all. Then due to the > > > "unevaluatedProperties: false", you'd get the warnings you want, at > > > validation time. > > > > Hm, with "unevaluatedProperties: false" i have no warnings. Even if I > > create examples with random strings as properties. Are there some new > > json libraries i should use? > > Try > > additionalProperties: False
Yes, it works. But in this case I'll do more changes. Just wont to make sure I do not fix not broken things.
Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |