lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address
On 08/11/2022, Christoph Hellwig wrote:
> On Tue, Aug 09, 2022 at 06:00:50PM +0000, Will McVicker wrote:
> > + bool msi_64b = false;
>
> Spellt out bit here?
>
> > + msi_capabilities = dw_pcie_msi_capabilities(pci);
> > + if (msi_capabilities & PCI_MSI_FLAGS_ENABLE)
> > + msi_64b = msi_capabilities & PCI_MSI_FLAGS_64BIT ? true : false;
>
> No need for the tenary operator here:
>
> msi_64bit = msi_capabilities & PCI_MSI_FLAGS_64BIT;

Thanks for the suggestions. I'll update in the next patchset.

\
 
 \ /
  Last update: 2022-08-11 19:08    [W:0.080 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site