Messages in this thread | | | Date | Thu, 11 Aug 2022 17:08:06 +0200 | Subject | Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes | From | Hans de Goede <> |
| |
Hi,
On 8/9/22 11:25, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev> wrote: >> >> Documents some previously added attributes: >> - dgpu_disable >> - egpu_enable >> - panel_od > > Try to find a commit that introduced thouse and add the respective Fixes tag. > > ... > >> - * keyboard - 0 or 1, unknown what effect this really has >> \ No newline at end of file >> + * keyboard - 0 or 1, unknown what effect this really has > > Should be part of another patch.
Ack to both remarks.
Luke please make this patch one of the first patches in your next version / patch-series and then add the doucmentation of the new kbd RGB backlight attributes in the patches where you are also adding those actual attributes.
Regards,
Hans
| |