Messages in this thread | | | From | Fabio Estevam <> | Date | Thu, 11 Aug 2022 11:04:27 -0300 | Subject | Re: [PATCH v3 2/2] arm64: dts: imx8mp-msc-sm2s: Add device trees for MSC SM2S-IMX8PLUS SoM and carrier board |
| |
On Thu, Jul 21, 2022 at 7:11 AM Martyn Welch <martyn.welch@collabora.com> wrote:
> +&eqos { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_eqos>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy0>; > + phy-reset-gpios = <&tca6424 16 GPIO_ACTIVE_LOW>; > + phy-reset-duration = <1>; > + phy-reset-post-delay = <1>; > + status = "okay"; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy0: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + eee-broken-1000t; > + phy-reset-gpios = <&tca6424 16 GPIO_ACTIVE_LOW>;
You have already added phy-reset-gpios above.
The phy-reset- properties are deprecated. It's better to use reset-gpios,reset-assert-us, etc inside the mdio node.
> +&fec { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_fec>; > + phy-mode = "rgmii-id"; > + phy-handle = <ðphy1>; > + phy-reset-gpios = <&tca6424 17 GPIO_ACTIVE_LOW>; > + phy-reset-duration = <1>; > + phy-reset-post-delay = <1>; > + fsl,magic-packet; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy1: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + eee-broken-1000t; > + phy-reset-gpios = <&tca6424 17 GPIO_ACTIVE_LOW>;
Same here.
> +&sdma1 { > + status = "okay";
No need to enable it as sdma1 is not disabled in imx8mp.dtsi.
| |