Messages in this thread | | | From | Kumar Kartikeya Dwivedi <> | Date | Thu, 11 Aug 2022 02:25:51 +0200 | Subject | Re: [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests |
| |
On Thu, 11 Aug 2022 at 01:16, Daniel Xu <dxu@dxuuu.xyz> wrote: > > This patchset adds more bpf_*_ct_lookup() selftests. The goal is to test > interaction with netfilter subsystem as well as reading from `struct > nf_conn`. The first is important when migrating legacy systems towards > bpf. The latter is important in general to take full advantage of > connection tracking. >
Thank you for contributing these tests. Feel free to add: Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
People often look at selftests for usage examples these days, so it's great to have coverage + examples for more use cases.
> I'll follow this patchset up with support for writing to `struct nf_conn`. >
Please also cc netfilter-devel, netdev, Pablo, and Florian when you send it.
I think we can directly enable stores to ct->mark, since that is what ctnetlink is doing too, so adding another helper for this would be unnecessary overhead.
> Past discussion: > - v2: https://lore.kernel.org/bpf/cover.1660062725.git.dxu@dxuuu.xyz/ > - v1: https://lore.kernel.org/bpf/cover.1659209738.git.dxu@dxuuu.xyz/ > > Changes since v2: > - Add bpf-ci kconfig changes > > Changes since v1: > - Reword commit message / cover letter to not mention connmark writing > > > Daniel Xu (3): > selftests/bpf: Add existing connection bpf_*_ct_lookup() test > selftests/bpf: Add connmark read test > selftests/bpf: Update CI kconfig > > tools/testing/selftests/bpf/config | 2 + > .../testing/selftests/bpf/prog_tests/bpf_nf.c | 60 +++++++++++++++++++ > .../testing/selftests/bpf/progs/test_bpf_nf.c | 21 +++++++ > 3 files changed, 83 insertions(+) > > -- > 2.37.1 >
| |