Messages in this thread | | | Date | Wed, 10 Aug 2022 16:16:23 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH 2/7] regulator: Add devm helpers for get and enable |
| |
On Wed, Aug 10, 2022 at 03:19:05PM +0300, Matti Vaittinen wrote:
> In order to tackle the issue the suggested API does not return handle to the > regulators - it really just provides the "get'n enable, then forget" > solution. The consumers who use the suggested API to "devm get'n enable" > will have had time manually controlling the regulator afterwards as they > will not get the handle. I would almost claim that the pattern we nowadays > see (devm_get, enable, add_action_or_reset(disable())) is more error prone > as users seem to in many case be storing the regulator handle w/o any > comment about the automated disable at detach.
Hrm, right - that does help with that case. However we do need a bulk version since that's an obvious problem case. [unhandled content-type:application/pgp-signature] | |