Messages in this thread | | | From | "Kalra, Ashish" <> | Subject | RE: [PATCH Part2 v6 02/49] iommu/amd: Introduce function to check SEV-SNP support | Date | Tue, 5 Jul 2022 14:53:22 +0000 |
| |
[AMD Official Use Only - General]
Hello Boris,
>> This function is required to ensure that IOMMU supports the SEV-SNP >> feature before enabling the SNP feature and calling SNP_INIT. >> This IOMMU support check is done in the AMD IOMMU driver with the >> iommu_sev_snp_supported() function so it is exported by the IOMMU >> driver and called by sev module
>What sev module?
I meant the kvm-amd module.
>The call to iommu_sev_snp_supported() is done by snp_rmptable_init() which is in arch/x86/kernel/sev.c. AFAICT.
>And that is not a module. But function exports are done for modules.
>So that export looks superfluous.
Yes realized this is called in arch/x86/kernel/sev.c, so yes the export is not needed and will remove it.
Thanks, Ashish
| |