lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 1/2] iio: humidity: hdc100x: switch to probe_new callback
On Fri, Jul 29, 2022 at 2:45 AM Potin Lai <potin.lai.pt@gmail.com> wrote:
> On 7/29/22 04:41, Andy Shevchenko wrote:
> > On Thu, Jul 28, 2022 at 3:32 PM Potin Lai <potin.lai.pt@gmail.com> wrote:
> >> Switch to probe_new callback due to probe is deprecated soon.
> > Just noticed that commit message is a bit not okay in a few ways:
> > 1) we refer to the callbacks like ->probe_new();

> > 2) we don't know when we deprecate it, the point here is not that, but
> > unused id parameter in the current code.

^^^ read this again and follow below.

> Thanks for point it out, is it OK leave the message as it is? or you prefer to submit another version to fix it?
> If new version required, I will also add another patch for struct device pointer you mentioned in the other reply.
>
> Just want to confirm that is the new message looks OK?
> New message:
> Switch ->porbe() to new callback ->probe_new()

You need to answer the question "why?" you are doing this and that.
The above is just saying "what?". See above.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-07-29 20:02    [W:0.041 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site