lkml.org 
[lkml]   [2022]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock
On Fri, 29 Jul 2022 18:34:39 +0800 Hangyu Hua wrote:
> >> thread1--->lock
> >> thread1--->dccp_qpolicy_full: queue is full. drop a skb
> >
> > This linie should say "not full"?
>
> dccp_qpolicy_full only call dccp_qpolicy_drop when queue is full. You
> can check out qpolicy_prio_full. qpolicy_prio_full will drop a skb to
> make suer there is enough space for the next data. So I think it should
> be "full" here.

Oh, I see what you're saying. That's unnecessarily complicated,
I reckon. The "simple" policy suffers from the same problem and
is easier to understand. Anyway, you already sent v2 and it doesn't
matter enough to warrant v3, so fine.

\
 
 \ /
  Last update: 2022-07-29 17:45    [W:0.048 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site