Messages in this thread | ![/](/images/icornerl.gif) | | From | Jiri Olsa <> | Date | Fri, 29 Jul 2022 13:42:40 +0200 | Subject | Re: [PATCH v2] perf parse-events: Break out tracepoint and printing. |
| |
On Thu, Jul 07, 2022 at 12:12:09PM -0700, Ian Rogers wrote:
SNIP
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 7ed235740431..206c76623c06 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -5,18 +5,12 @@ > #include <dirent.h> > #include <errno.h> > #include <sys/ioctl.h> > -#include <sys/types.h> > -#include <sys/stat.h> > -#include <fcntl.h> > #include <sys/param.h> > #include "term.h" > -#include "build-id.h" > #include "evlist.h" > #include "evsel.h" > -#include <subcmd/pager.h> > #include <subcmd/parse-options.h> > #include "parse-events.h" > -#include <subcmd/exec-cmd.h> > #include "string2.h" > #include "strlist.h" > #include "bpf-loader.h" > @@ -24,23 +18,24 @@ > #include <api/fs/tracing_path.h> > #include <perf/cpumap.h> > #include "parse-events-bison.h" > -#define YY_EXTRA_TYPE void* > #include "parse-events-flex.h"
hum, why is this not needed anymore?
> #include "pmu.h" > -#include "thread_map.h" > -#include "probe-file.h" > #include "asm/bug.h" > #include "util/parse-branch-options.h" > -#include "metricgroup.h" > #include "util/evsel_config.h" > #include "util/event.h" > -#include "util/pfm.h" > +#include "perf.h" > #include "util/parse-events-hybrid.h" > #include "util/pmu-hybrid.h" > -#include "perf.h" > +#include "tracepoint.h" > > #define MAX_NAME_LEN 100 >
SNIP
| ![\](/images/icornerr.gif) |