Messages in this thread | | | Date | Thu, 28 Jul 2022 18:36:12 +0530 | Subject | Re: [PATCH] ASoC: qcom: SC7280: Add support for external DMIC bias supply | From | Srinivasa Rao Mandadapu <> |
| |
On 7/28/2022 4:19 PM, Mark Brown wrote: Thanks for your time Mark!!! > On Thu, Jul 28, 2022 at 12:40:33PM +0530, Srinivasa Rao Mandadapu wrote: > >> +static int sc7280_dmic_micbias(struct snd_soc_dapm_widget *w, >> + struct snd_kcontrol *kcontrol, int event) >> +{ >> + struct snd_soc_card *card = w->dapm->card; >> + struct sc7280_snd_data *data = snd_soc_card_get_drvdata(card); >> + int ret = 0; >> + > This is open coding SND_SOC_DAPM_REGULATOR_SUPPLY() isn't it?
Yes, agree that SND_SOC_DAPM_REGULATOR_SUPPLY can be used here. As I was using two different names for
VDD supply property and widget name, got confused. I will re post the patch, with single name for both and replace with above macro .
| |