lkml.org 
[lkml]   [2022]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call
Date
Hi Peter,

> -----Original Message-----
> From: Peter Suti <peter.suti@streamunlimited.com>
> Sent: Wednesday, July 27, 2022 3:36 PM
> To: Liu, Chuansheng <chuansheng.liu@intel.com>; dan.carpenter@oracle.com;
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Thomas Zimmermann
> <tzimmermann@suse.de>; Javier Martinez Canillas <javierm@redhat.com>
> Cc: Peter Suti <peter.suti@streamunlimited.com>; dri-
> devel@lists.freedesktop.org; linux-fbdev@vger.kernel.org; linux-
> staging@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: [PATCH v3] staging: fbtft: core: set smem_len before
> fb_deferred_io_init call
>
> The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
> initializing info->fix.smem_len. It is set to zero by the
> framebuffer_alloc() function. It will trigger a WARN_ON() at the
> start of fb_deferred_io_init() and the function will not do anything.

Please show us the WARN_ON() call stack, then everything is clear. It is the driver itself issue to be fixed.
I saw Thomas made such WARN_ON().

>
> Fixes: 856082f021a2 ("fbdev: defio: fix the pagelist corruption")

Don't agree with such description.

Best Regards
Chuansheng


\
 
 \ /
  Last update: 2022-07-28 14:50    [W:0.084 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site