Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 28 Jul 2022 17:36:15 +0530 | From | Pratyush Yadav <> | Subject | Re: [PATCH] mtd: spi-nor: core: Add an error message when failing to exit the 4-byte address mode |
| |
On 28/07/22 06:01AM, Tudor Ambarus wrote: > Add an error message when failing to exit the 4-byte address mode. Do not > stop the execution and go through the spi_nor_soft_reset() method if used, > in the hope that the flash will default to 3-byte address mode after the > reset. > > Suggested-by: Pratyush Yadav <p.yadav@ti.com> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
> --- > drivers/mtd/spi-nor/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index f2c64006f8d7..1cdbdad97136 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -2841,7 +2841,8 @@ void spi_nor_restore(struct spi_nor *nor) > /* restore the addressing mode */ > if (nor->addr_nbytes == 4 && !(nor->flags & SNOR_F_4B_OPCODES) && > nor->flags & SNOR_F_BROKEN_RESET) > - nor->params->set_4byte_addr_mode(nor, false); > + if (nor->params->set_4byte_addr_mode(nor, false)) > + dev_err(nor->dev, "Failed to exit 4-byte address mode\n"); > > if (nor->flags & SNOR_F_SOFT_RESET) > spi_nor_soft_reset(nor); > -- > 2.25.1 >
-- Regards, Pratyush Yadav Texas Instruments Inc.
| ![\](/images/icornerr.gif) |