lkml.org 
[lkml]   [2022]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
Date
[AMD Official Use Only - General]

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, May 6, 2022 2:20 AM
> To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Cc: linux-serial@vger.kernel.org; michal.simek@xilinx.com;
> jirislaby@kernel.org; git@xilinx.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
>
> On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote:
> > Check the clk_enable return value.
>
> That says what, but not why.
>
Will fix v2.
> >
> > Addresses-Coverity: Event check_return.
>
> Shouldn't this be a covertity id?

I could not find the warning in the Coverity that is run on the linux kernel.
Somehow was seeing int when I was running locally.

>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2022-07-28 13:10    [W:0.054 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site