Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 28 Jul 2022 17:14:35 +0800 | Subject | Re: [PATCH v2] memblock test: Modify the obsolete description in README | From | "Huang, Shaoqin" <> |
| |
On 7/28/2022 5:01 PM, Mike Rapoport wrote: > On Thu, Jul 28, 2022 at 01:08:25PM +0800, Huang, Shaoqin wrote: >> >> >> On 7/28/2022 12:05 PM, Rebecca Mckeever wrote: >>> On Wed, Jul 27, 2022 at 07:12:28PM -0600, shaoqin.huang@intel.com wrote: >>>> From: Shaoqin Huang <shaoqin.huang@intel.com> >>>> >>>> The VERBOSE option in Makefile has been moved, but there still have the >>>> description left in README. For now, we use `-v` options when running >>>> memblock test to print information, so using the new to replace the >>>> obsolete items. >>>> >>> Thanks for catching this! >>> >>>> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com> >>>> --- > > ... > >>>> This will print information about which functions are being tested and the >>>> number of test cases that passed. >>>> -To simulate enabled NUMA, use: >>>> +For the full list of options from command line, see `./main --help`. >>> >>> --help will display the list of command line options by default, but a >>> help command line option isn't explicitly implemented. I'm planning to add >>> the help option, so if you want to remove this sentence, I will add it when >>> I implement the help option. >> >> Hi, Rebecca. >> >> That's ok. I didn't notice the --help has not been implemented. So I can >> remove the line: >> -For the full list of options from command line, see `./main --help`. >> >> But after remove it. There seems a little stranger about how to get the full >> list of options at the time. How do you think about it? > > I '--help' option is implemented, it just does not list help for itself. > I think it's fine to keep the "For the full list..." line. > >
Ok, if no other problem. I will resend this patch with a minimal tweak: -For the full list of options, see `make help`. +For the full list of build options, see `make help`.
| ![\](/images/icornerr.gif) |