Messages in this thread | | | Date | Fri, 29 Jul 2022 13:49:48 +1000 | From | Nicholas Piggin <> | Subject | Re: [PATCH v2 06/12] locking/qspinlock: merge qspinlock_paravirt.h into qspinlock.c |
| |
Excerpts from kernel test robot's message of July 15, 2022 12:16 am: > Hi Nicholas, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on tip/locking/core] > [also build test WARNING on tip/x86/core powerpc/next linus/master v5.19-rc6 next-20220714] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Nicholas-Piggin/locking-qspinlock-simplify-code-generation/20220713-151009 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git eae6d58d67d9739be5f7ae2dbead1d0ef6528243 > config: i386-randconfig-a004 > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61b9c556267086ef9b743a0b57df302eef831b) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/91668ee1ed703d7ea84e314136dc732da05ec9e7 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Nicholas-Piggin/locking-qspinlock-simplify-code-generation/20220713-151009 > git checkout 91668ee1ed703d7ea84e314136dc732da05ec9e7 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/locking/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > In file included from kernel/locking/qspinlock.c:29: > kernel/locking/qspinlock_stat.h:36:9: warning: no previous prototype for function 'lockevent_read' [-Wmissing-prototypes] > ssize_t lockevent_read(struct file *file, char __user *user_buf, > ^ > kernel/locking/qspinlock_stat.h:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > ssize_t lockevent_read(struct file *file, char __user *user_buf, > ^ > static >>> kernel/locking/qspinlock.c:705:1: warning: no previous prototype for function '__pv_queued_spin_unlock_slowpath' [-Wmissing-prototypes] > __pv_queued_spin_unlock_slowpath(struct qspinlock *lock, u8 locked) > ^ > kernel/locking/qspinlock.c:704:11: note: declare 'static' if the function is not intended to be used outside of this translation unit > __visible void > ^ > static > 2 warnings generated.
These aren't new warnings btw, just existing W=1 warnings in code that moved.
Thanks, Nick
| |