lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 53/62] tty: drivers/tty/, stop using tty_schedule_flip()
    Date
    From: Jiri Slaby <jslaby@suse.cz>

    commit 5f6a85158ccacc3f09744b3aafe8b11ab3b6c6f6 upstream.

    Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,
    tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). We are
    going to remove the latter (as it is used less), so call the former in
    drivers/tty/.

    Cc: Vladimir Zapolskiy <vz@mleia.com>
    Reviewed-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Link: https://lore.kernel.org/r/20211122111648.30379-2-jslaby@suse.cz
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/tty/cyclades.c | 6 +++---
    drivers/tty/goldfish.c | 2 +-
    drivers/tty/moxa.c | 4 ++--
    drivers/tty/serial/lpc32xx_hs.c | 2 +-
    drivers/tty/vt/keyboard.c | 6 +++---
    drivers/tty/vt/vt.c | 2 +-
    6 files changed, 11 insertions(+), 11 deletions(-)

    --- a/drivers/tty/cyclades.c
    +++ b/drivers/tty/cyclades.c
    @@ -556,7 +556,7 @@ static void cyy_chip_rx(struct cyclades_
    }
    info->idle_stats.recv_idle = jiffies;
    }
    - tty_schedule_flip(port);
    + tty_flip_buffer_push(port);

    /* end of service */
    cyy_writeb(info, CyRIR, save_xir & 0x3f);
    @@ -996,7 +996,7 @@ static void cyz_handle_rx(struct cyclade
    mod_timer(&info->rx_full_timer, jiffies + 1);
    #endif
    info->idle_stats.recv_idle = jiffies;
    - tty_schedule_flip(&info->port);
    + tty_flip_buffer_push(&info->port);

    /* Update rx_get */
    cy_writel(&buf_ctrl->rx_get, new_rx_get);
    @@ -1172,7 +1172,7 @@ static void cyz_handle_cmd(struct cyclad
    if (delta_count)
    wake_up_interruptible(&info->port.delta_msr_wait);
    if (special_count)
    - tty_schedule_flip(&info->port);
    + tty_flip_buffer_push(&info->port);
    }
    }

    --- a/drivers/tty/goldfish.c
    +++ b/drivers/tty/goldfish.c
    @@ -151,7 +151,7 @@ static irqreturn_t goldfish_tty_interrup
    address = (unsigned long)(void *)buf;
    goldfish_tty_rw(qtty, address, count, 0);

    - tty_schedule_flip(&qtty->port);
    + tty_flip_buffer_push(&qtty->port);
    return IRQ_HANDLED;
    }

    --- a/drivers/tty/moxa.c
    +++ b/drivers/tty/moxa.c
    @@ -1393,7 +1393,7 @@ static int moxa_poll_port(struct moxa_po
    if (inited && !tty_throttled(tty) &&
    MoxaPortRxQueue(p) > 0) { /* RX */
    MoxaPortReadData(p);
    - tty_schedule_flip(&p->port);
    + tty_flip_buffer_push(&p->port);
    }
    } else {
    clear_bit(EMPTYWAIT, &p->statusflags);
    @@ -1418,7 +1418,7 @@ static int moxa_poll_port(struct moxa_po

    if (tty && (intr & IntrBreak) && !I_IGNBRK(tty)) { /* BREAK */
    tty_insert_flip_char(&p->port, 0, TTY_BREAK);
    - tty_schedule_flip(&p->port);
    + tty_flip_buffer_push(&p->port);
    }

    if (intr & IntrLine)
    --- a/drivers/tty/serial/lpc32xx_hs.c
    +++ b/drivers/tty/serial/lpc32xx_hs.c
    @@ -341,7 +341,7 @@ static irqreturn_t serial_lpc32xx_interr
    LPC32XX_HSUART_IIR(port->membase));
    port->icount.overrun++;
    tty_insert_flip_char(tport, 0, TTY_OVERRUN);
    - tty_schedule_flip(tport);
    + tty_flip_buffer_push(tport);
    }

    /* Data received? */
    --- a/drivers/tty/vt/keyboard.c
    +++ b/drivers/tty/vt/keyboard.c
    @@ -310,7 +310,7 @@ int kbd_rate(struct kbd_repeat *rpt)
    static void put_queue(struct vc_data *vc, int ch)
    {
    tty_insert_flip_char(&vc->port, ch, 0);
    - tty_schedule_flip(&vc->port);
    + tty_flip_buffer_push(&vc->port);
    }

    static void puts_queue(struct vc_data *vc, char *cp)
    @@ -319,7 +319,7 @@ static void puts_queue(struct vc_data *v
    tty_insert_flip_char(&vc->port, *cp, 0);
    cp++;
    }
    - tty_schedule_flip(&vc->port);
    + tty_flip_buffer_push(&vc->port);
    }

    static void applkey(struct vc_data *vc, int key, char mode)
    @@ -564,7 +564,7 @@ static void fn_inc_console(struct vc_dat
    static void fn_send_intr(struct vc_data *vc)
    {
    tty_insert_flip_char(&vc->port, 0, TTY_BREAK);
    - tty_schedule_flip(&vc->port);
    + tty_flip_buffer_push(&vc->port);
    }

    static void fn_scroll_forw(struct vc_data *vc)
    --- a/drivers/tty/vt/vt.c
    +++ b/drivers/tty/vt/vt.c
    @@ -1838,7 +1838,7 @@ static void respond_string(const char *p
    tty_insert_flip_char(port, *p, 0);
    p++;
    }
    - tty_schedule_flip(port);
    + tty_flip_buffer_push(port);
    }

    static void cursor_report(struct vc_data *vc, struct tty_struct *tty)

    \
     
     \ /
      Last update: 2022-07-27 18:37    [W:7.022 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site