lkml.org 
[lkml]   [2022]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] tirnity: Add dma memory module
    On Mon, Jul 25, 2022 at 03:53:01PM +0900, Jiho Chu wrote:
    > This patch includes memory management module.
    >
    > It provides abstraction layer to handle DMA buffer.

    Again, no abstactions please. Get this working and merged properly
    first, before worrying about any sort of additional hardware models or
    abstractions. It just makes this so much harder to review and to
    determine what you really are, or are not, using here.

    So far, it seems you aren't using any of these new abstractions, which
    is odd. Or I just can't find them. Either way that's a huge sign this
    code is wrong and needs to be cleaned up.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2022-07-27 15:16    [W:6.613 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site