Messages in this thread | | | Date | Wed, 27 Jul 2022 15:15:25 +0200 | From | Greg KH <> | Subject | Re: [PATCH 2/9] tirnity: Add dma memory module |
| |
On Mon, Jul 25, 2022 at 03:53:01PM +0900, Jiho Chu wrote: > This patch includes memory management module. > > It provides abstraction layer to handle DMA buffer.
Again, no abstactions please. Get this working and merged properly first, before worrying about any sort of additional hardware models or abstractions. It just makes this so much harder to review and to determine what you really are, or are not, using here.
So far, it seems you aren't using any of these new abstractions, which is odd. Or I just can't find them. Either way that's a huge sign this code is wrong and needs to be cleaned up.
thanks,
greg k-h
| |