Messages in this thread | | | Subject | RE:(2) [PATCH v4 5/7] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() | From | Jinyoung CHOI <> | Date | Thu, 28 Jul 2022 10:18:56 +0900 |
| |
>On 7/27/22 00:10, Jinyoung CHOI wrote: >> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h >> index 94bcfec98fb8..78adc556444a 100644 >> --- a/include/ufs/ufshcd.h >> +++ b/include/ufs/ufshcd.h >> @@ -1017,6 +1017,12 @@ static inline bool ufshcd_is_wb_allowed(struct ufs_hba *hba) >> return hba->caps & UFSHCD_CAP_WB_EN; >> } >> >> +static inline bool ufshcd_is_wb_buf_flush_allowed(struct ufs_hba *hba) >> +{ >> + return ufshcd_is_wb_allowed(hba) && >> + !(hba->quirks & UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL); >> +} > >Since this function is only used inside the UFS driver core it should be >added in drivers/ufs/core/ufshcd-priv.h instead of include/ufs/ufshcd.h. > >Thanks, > >Bart.
OK, I will move it. I didn't know the exact purpose of ufshcd-priv.h. Thank you for telling me.
Thanks, Jinyoung.
| |