lkml.org 
[lkml]   [2022]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 5/7] drm/msm/dsi: Use the new regulator bulk feature to specify the load
    Date
    As of the patch ("regulator: core: Allow specifying an initial load w/
    the bulk API") we can now specify the initial load in the bulk data
    rather than having to manually call regulator_set_load() on each
    regulator. Let's use it.

    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    ---

    Changes in v2:
    - ("Use the new regulator bulk feature to specify the load") new for v2.

    drivers/gpu/drm/msm/dsi/dsi_host.c | 13 +++----------
    drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 13 +++----------
    2 files changed, 6 insertions(+), 20 deletions(-)

    diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
    index 04265ad2fbef..dec7a94cf819 100644
    --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
    +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
    @@ -279,8 +279,10 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host)
    int num = msm_host->cfg_hnd->cfg->reg_cfg.num;
    int i, ret;

    - for (i = 0; i < num; i++)
    + for (i = 0; i < num; i++) {
    s[i].supply = regs[i].name;
    + s[i].init_load_uA = regs[i].enable_load;
    + }

    ret = devm_regulator_bulk_get(&msm_host->pdev->dev, num, s);
    if (ret < 0) {
    @@ -289,15 +291,6 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host)
    return ret;
    }

    - for (i = 0; i < num; i++) {
    - if (regs[i].enable_load >= 0) {
    - ret = regulator_set_load(s[i].consumer,
    - regs[i].enable_load);
    - if (ret < 0)
    - return ret;
    - }
    - }
    -
    return 0;
    }

    diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
    index 330c0c4e7f9d..f42ff57861da 100644
    --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
    +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
    @@ -515,8 +515,10 @@ static int dsi_phy_regulator_init(struct msm_dsi_phy *phy)
    int num = phy->cfg->reg_cfg.num;
    int i, ret;

    - for (i = 0; i < num; i++)
    + for (i = 0; i < num; i++) {
    s[i].supply = regs[i].name;
    + s[i].init_load_uA = regs[i].enable_load;
    + }

    ret = devm_regulator_bulk_get(dev, num, s);
    if (ret < 0) {
    @@ -529,15 +531,6 @@ static int dsi_phy_regulator_init(struct msm_dsi_phy *phy)
    return ret;
    }

    - for (i = 0; i < num; i++) {
    - if (regs[i].enable_load >= 0) {
    - ret = regulator_set_load(s[i].consumer,
    - regs[i].enable_load);
    - if (ret < 0)
    - return ret;
    - }
    - }
    -
    return 0;
    }

    --
    2.37.1.359.gd136c6c3e2-goog
    \
     
     \ /
      Last update: 2022-07-26 19:39    [W:3.338 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site