lkml.org 
[lkml]   [2022]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH Part2 v6 06/49] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
    On Mon, Jun 20, 2022 at 11:02:52PM +0000, Ashish Kalra wrote:
    > diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h
    > index cb16f0e5b585..6ab872311544 100644
    > --- a/arch/x86/include/asm/sev.h
    > +++ b/arch/x86/include/asm/sev.h
    > @@ -85,7 +85,9 @@ extern bool handle_vc_boot_ghcb(struct pt_regs *regs);
    >
    > /* RMP page size */
    > #define RMP_PG_SIZE_4K 0
    > +#define RMP_PG_SIZE_2M 1
    > #define RMP_TO_X86_PG_LEVEL(level) (((level) == RMP_PG_SIZE_4K) ? PG_LEVEL_4K : PG_LEVEL_2M)
    > +#define X86_TO_RMP_PG_LEVEL(level) (((level) == PG_LEVEL_4K) ? RMP_PG_SIZE_4K : RMP_PG_SIZE_2M)
    >
    > /*
    > * The RMP entry format is not architectural. The format is defined in PPR
    > @@ -126,6 +128,15 @@ struct snp_guest_platform_data {
    > u64 secrets_gpa;
    > };
    >
    > +struct rmpupdate {

    Why is there a struct rmpupdate *and* a struct rmpentry?!

    One should be enough.

    > + u64 gpa;
    > + u8 assigned;
    > + u8 pagesize;
    > + u8 immutable;
    > + u8 rsvd;
    > + u32 asid;
    > +} __packed;
    > +

    --
    Regards/Gruss,
    Boris.
    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2022-07-25 16:38    [W:2.239 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site