Messages in this thread | | | Date | Sun, 24 Jul 2022 20:41:01 -0500 | From | Segher Boessenkool <> | Subject | Re: [PATCH] powerpc/purgatory: Omit use of bin2c |
| |
On Sun, Jun 26, 2022 at 07:40:37AM +0900, Masahiro Yamada wrote: > The .incbin assembler directive is much faster than bin2c + $(CC).
And perhaps more importantly it is simpler and less clumsy.
> --- /dev/null > +++ b/arch/powerpc/purgatory/kexec-purgatory.S > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > + .section .rodata, "a" > + > + .align 8 > +kexec_purgatory: > + .globl kexec_purgatory > + .incbin "arch/powerpc/purgatory/purgatory.ro" > +.Lkexec_purgatroy_end:
Typo here (s/ro/or/)
> + > + .align 8 > +kexec_purgatory_size: > + .globl kexec_purgatory_size > + .quad .Lkexec_purgatroy_end - kexec_purgatory
And here again ofc.
Looks good to me otherwise, nice cleanup :-)
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
| |