Messages in this thread | | | Subject | Re: [PATCH v4 3/5] lib/test: Introduce cpumask KUnit test suite | From | Sander Vanheule <> | Date | Wed, 20 Jul 2022 14:47:28 +0200 |
| |
Hi,
On Tue, 2022-07-19 at 18:31 -0300, Maíra Canal wrote: > > Add a basic suite of tests for cpumask, providing some tests for empty > > and completely filled cpumasks. > > > > Signed-off-by: Sander Vanheule <sander@svanheule.net> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > The tests test_cpumask_weight and test_cpumask_last are failing on all > architectures, as can be seen on [1]. Also this test doesn't follow the > standard style for KUnit tests [2]. > > [1] > https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220718/testrun/10865066/suite/kunit/tests/ > [2] https://docs.kernel.org/dev-tools/kunit/style.html
Thanks for the feedback, I wasn't aware of the style guidelines. See my reply to David's message for the issues with the cpu_possible_mask tests.
Andrew, would you like me to resubmit the entire series, or can I just send a new version of this patch?
Best, Sander
| |