lkml.org 
[lkml]   [2022]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V3 11/12] KVM: X86/MMU: Don't use mmu->pae_root when shadowing PAE NPT in 64-bit host
    On Tue, Jul 19, 2022, Sean Christopherson wrote:
    > On Sat, May 21, 2022, Lai Jiangshan wrote:
    > Actually, I think the series is buggy. That patch, which precedes this one, does
    >
    > if (vcpu->arch.mmu->root_role.level != PT32E_ROOT_LEVEL)
    > return 0;
    >
    > i.e. does NOT allocate pae_root for a 64-bit host, which means that running KVM
    > against the on-demand patch would result in the WARN firing and bad things happening.

    Gah, I take that back, pae_root is allocated by mmu_alloc_special_roots().

    \
     
     \ /
      Last update: 2022-07-20 01:28    [W:2.708 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site