lkml.org 
[lkml]   [2022]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] KVM: arm64: Fix hypervisor address symbolization
    On Mon, Jul 18, 2022 at 2:08 AM Fuad Tabba <tabba@google.com> wrote:
    >
    > Hi Kalesh,
    >
    > On Sat, Jul 16, 2022 at 12:58 AM Kalesh Singh <kaleshsingh@google.com> wrote:
    > >
    > > With CONFIG_RANDOMIZE_BASE=y vmlinux addresses will resolve correctly
    > > from kallsyms. Fix this by adding the KASLR offset before printing the
    > > symbols.
    > >
    > > Based on arm64 for-next/stacktrace.
    > >
    > > Fixes: 6ccf9cb557bd ("KVM: arm64: Symbolize the nVHE HYP addresses")
    > > Reported-by: Fuad Tabba <tabba@google.com>
    > > Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
    > > ---
    >
    > Even with this patch applied I still don't get symbolization unless I
    > disable randomization, either by setting CONFIG_RANDOMIZE_BASE=n or
    > pass nokaslr as a kernel parameter. I tried both and in either case it
    > works.

    Hi Fuad,

    Thanks for testing it. The fix only addressed the symbolization for
    the hyp panic address. I plan to fix the symbolization of stacktrace
    in the next version of this series.

    --Kalesh

    >
    > Thanks,
    > /fuad
    >
    >
    > > arch/arm64/kvm/handle_exit.c | 4 ++--
    > > 1 file changed, 2 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
    > > index f66c0142b335..e43926ef2bc2 100644
    > > --- a/arch/arm64/kvm/handle_exit.c
    > > +++ b/arch/arm64/kvm/handle_exit.c
    > > @@ -347,10 +347,10 @@ void __noreturn __cold nvhe_hyp_panic_handler(u64 esr, u64 spsr,
    > > kvm_err("nVHE hyp BUG at: %s:%u!\n", file, line);
    > > else
    > > kvm_err("nVHE hyp BUG at: [<%016llx>] %pB!\n", panic_addr,
    > > - (void *)panic_addr);
    > > + (void *)(panic_addr + kaslr_offset()));
    > > } else {
    > > kvm_err("nVHE hyp panic at: [<%016llx>] %pB!\n", panic_addr,
    > > - (void *)panic_addr);
    > > + (void *)(panic_addr + kaslr_offset()));
    > > }
    > >
    > > /*
    > >
    > > base-commit: 82a592c13b0aeff94d84d54183dae0b26384c95f
    > > --
    > > 2.37.0.170.g444d1eabd0-goog
    > >

    \
     
     \ /
      Last update: 2022-07-18 19:10    [W:9.034 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site