Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Jul 2022 15:40:49 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH v2 12/21] KVM: x86: Make kvm_queued_exception a properly named, visible struct |
| |
On Mon, Jul 18, 2022, Maxim Levitsky wrote: > On Mon, 2022-07-18 at 16:07 +0300, Maxim Levitsky wrote: > > On Tue, 2022-06-14 at 20:47 +0000, Sean Christopherson wrote: > > > Move the definition of "struct kvm_queued_exception" out of kvm_vcpu_arch > > > in anticipation of adding a second instance in kvm_vcpu_arch to handle > > > exceptions that occur when vectoring an injected exception and are > > > morphed to VM-Exit instead of leading to #DF. > > > > > > Opportunistically take advantage of the churn to rename "nr" to "vector". > > > > > > No functional change intended. > > > > > > Signed-off-by: Sean Christopherson <seanjc@google.com> > > > --- > > > > > ... > > > > > > Is this change below intentional? My memory on nested_apf_token is quite rusty, but at least > > if possible, I would prefer this to be done in separate patch.
Yikes! It's not intention as of this patch. It _is_ intentional for the "morph" patch, as KVM can simply force "has_payload" in kvm_inject_page_fault() when directly queueing the VM-Exit. I suspect I botched this patch when splitting the original changes into separate patches.
> Sorry, I replied to the wrong mail, but the newer version also has the same issue. > (It should be v3 btw.)
Argh, sorry about the versioning mixup. I distinctly remember thinking this couldn't possibly have been only the second version... Should have double-checked instead of trusting my archive.
| ![\](/images/icornerr.gif) |